[REF] Replace deprecated function call with a more readable alternative #15489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a wrapper to getting financial accounts with the type. We could call the other directly but it's less readable & requires the account name to be specified which feels like a look-up for devs
|
(Standard links)
|
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a wrapper to getting financial accounts with the type & uses it rather than the non-deprecated function
Before
Deprecated function called
After
More readable function called
Technical Details
@monishdeb I'd like to advocate for functions like this for getting the financial accounts. They are a pretty thin wrapper on getFinancialAccountForFinancialTypeByRelationship but I feel it's more readable & less error prone (no need to get 'Sales Account Is' exactly right, instead use IDE autocomplete)
Comments